fix AutoCloseableLifecycleComponent close exception log #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun failure checks |
1 similar comment
|
rerun failure checks |
hangc0276
approved these changes
Aug 8, 2023
|
rerun failure checks |
|
@StevenLuMT @eolivelli @zymap PTAL |
zymap
approved these changes
Aug 9, 2023
horizonzy
reviewed
Aug 9, 2023
Thanks. Updated. |
dlg99
approved these changes
Aug 10, 2023
zymap
pushed a commit
that referenced
this pull request
Aug 29, 2023
Descriptions of the changes in this PR: ### Motivation If closed with exception, the log will always be `failed to close AutoCloseableLifecycleComponent`. It will be better to print the `componentName` instead of the class name. ### Changes Print the `componentName` instead of `AutoCloseableLifecycleComponent` class name if closed with exception (cherry picked from commit 269374f)
zymap
pushed a commit
that referenced
this pull request
Dec 7, 2023
Descriptions of the changes in this PR: ### Motivation If closed with exception, the log will always be `failed to close AutoCloseableLifecycleComponent`. It will be better to print the `componentName` instead of the class name. ### Changes Print the `componentName` instead of `AutoCloseableLifecycleComponent` class name if closed with exception (cherry picked from commit 269374f)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Descriptions of the changes in this PR: ### Motivation If closed with exception, the log will always be `failed to close AutoCloseableLifecycleComponent`. It will be better to print the `componentName` instead of the class name. ### Changes Print the `componentName` instead of `AutoCloseableLifecycleComponent` class name if closed with exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
If closed with exception, the log will always be
failed to close AutoCloseableLifecycleComponent. It will be better to print thecomponentNameinstead of the class name.Changes
Print the
componentNameinstead ofAutoCloseableLifecycleComponentclass name if closed with exception