[release] Force to use linux/amd64 to build release #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation Because we have a Native IO that needs to be built from cpp code. The build platform will impact the target library. People are using different laptop to execute the release process with docker, we need to force the image to use linux/amd64 platform to ensure the .so lib build out the correct platform lib. Since most of time we are using amd64 to run the bookie, making the dev docker image build from amd64.
shoothzj
approved these changes
Aug 28, 2023
hangc0276
approved these changes
Aug 28, 2023
zymap
added a commit
that referenced
this pull request
Aug 29, 2023
--- ### Motivation Because we have a Native IO that needs to be built from cpp code. The build platform will impact the target library. People are using different laptop to execute the release process with docker, we need to force the image to use linux/amd64 platform to ensure the .so lib build out the correct platform lib. Since most of time we are using amd64 to run the bookie, making the dev docker image build from amd64. (cherry picked from commit 5a47c1d)
zymap
added a commit
that referenced
this pull request
Dec 7, 2023
--- ### Motivation Because we have a Native IO that needs to be built from cpp code. The build platform will impact the target library. People are using different laptop to execute the release process with docker, we need to force the image to use linux/amd64 platform to ensure the .so lib build out the correct platform lib. Since most of time we are using amd64 to run the bookie, making the dev docker image build from amd64. (cherry picked from commit 5a47c1d)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
--- ### Motivation Because we have a Native IO that needs to be built from cpp code. The build platform will impact the target library. People are using different laptop to execute the release process with docker, we need to force the image to use linux/amd64 platform to ensure the .so lib build out the correct platform lib. Since most of time we are using amd64 to run the bookie, making the dev docker image build from amd64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Because we have a Native IO that needs to be built from cpp code. The build platform will impact the target library. People are using different laptop to execute the release process with docker, we need to force the image to use linux/amd64 platform to ensure the .so lib build out the correct platform lib.
Since most of time we are using amd64 to run the bookie, making the dev docker image build from amd64.
Changes
Update the dev Dockerfile to use the specified platform.