Fix ledgerHandle pendingAddEntries stats #4104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested changes
Oct 26, 2023
| @@ -92,6 +92,8 @@ | |||
| * write operations to a ledger. | |||
| */ | |||
| public class LedgerHandle implements WriteHandle { | |||
| public static Set<LedgerHandle> INSTANCES = ConcurrentHashMap.newKeySet(); | |||
There was a problem hiding this comment.
Store the LedgerHandle object will bring extra memory overload for the client.
hangc0276
requested review from
dlg99,
eolivelli,
zymap,
wenbingshen and
StevenLuMT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current LedgerHandle stats NUM_PENDING_ADD only record the first LedgerHandle create by bookkeeper instance.
if we need record all LedgerHandle at bookkeeper instance level the goal fail.
Changes