Ignore the empty perRegionPlacement when RegionAwareEnsemblePlacementPolicy#newEnsemble
#4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
approved these changes
Oct 17, 2023
| for (String region: perRegionPlacement.keySet()) { | ||
| if ((null == disallowBookiePlacementInRegionFeatureName) | ||
| for (Map.Entry<String, TopologyAwareEnsemblePlacementPolicy> entry : perRegionPlacement.entrySet()) { | ||
| String region = entry.getKey(); |
There was a problem hiding this comment.
We can filter the empty region in the beginning
if (entry.getValue().knownBookies.isEmpty()) {
continue;
}
yangl
approved these changes
Oct 18, 2023
zymap
approved these changes
Oct 18, 2023
yangl
pushed a commit
to yangl/bookkeeper
that referenced
this pull request
Dec 11, 2023
…ntPolicy#newEnsemble (apache#4106) Descriptions of the changes in this PR: If the `perRegionPlacement` available bookies are empty, do not pick a bookie from it.
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Jan 18, 2024
…ntPolicy#newEnsemble (apache#4106) Descriptions of the changes in this PR: If the `perRegionPlacement` available bookies are empty, do not pick a bookie from it. (cherry picked from commit 3221aa3)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…ntPolicy#newEnsemble (apache#4106) Descriptions of the changes in this PR: If the `perRegionPlacement` available bookies are empty, do not pick a bookie from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
If the
perRegionPlacementavailable bookies are empty, do not pick a bookie from it.