CALCITE-6465: Rework code generator to use Flink code splitter #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This builds but introduces a dependency on flink-core. Looking for a way around this. |
davidradl
reviewed
Sep 10, 2024
| // more than 8K byte code." | ||
| final int flinkDefaultMaxGeneratedCodeLength = 4000; | ||
|
|
||
| // From Flink TableConfigOptions.MAX_MEMBERS_GENERATED_CODE |
There was a problem hiding this comment.
these Flink considerations seem inappropriate in Calcite, unless we can make them generic so we do not reference Flink at all.
There was a problem hiding this comment.
I've removed references to Flink here.
Integrate Flink Java code splitter and run it on all final Expressions when converting to Java code. Next step is to run it based on configuration options
JavaCodeSplitter needs it for Preconditions
jduo
commented
Sep 20, 2024
| @@ -51,7 +51,7 @@ public Type getType() { | |||
| } | |||
|
|
|||
| @Override public String toString() { | |||
| ExpressionWriter writer = new ExpressionWriter(true); | |||
| ExpressionWriter writer = new ExpressionWriter(true, true); | |||
There was a problem hiding this comment.
Ideally this would read from the CalciteSystemProperty but calcite-core depends on linq4j so it can't be looked up here.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.