[CALCITE-6574] SqlValidatorImpl Refactor: SqlQueryScopes #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesstarr
force-pushed
the
CALCITE-6574
branch
4 times, most recently
from
ae1c576
to
6afa729
Compare
Adding SqlQueryScopes to encapsulate the data for resolving SqlNode to SqlValidatorScope and SqlValidatorNamespaces. Moving the api for resolving scopes from SqlValidator to SqlQueryScopes.
jamesstarr
force-pushed
the
CALCITE-6574
branch
from
6afa729
to
6c7659f
Compare
|
@mihaibudiu This is ready for review. @julianhyde Please let me know if you have an objections or would like any changes. |
… using a generic Fuction in SqlValiator.Config.
AbstractNamespace and ListScope.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SqlQueryScopes to encapsulate the data for resolving SqlNode to SqlValidatorScope. Shift the api for resolving scopes from SqlValidator to SqlQueryScopes.