Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently support "cloudEventsType" property in Pipes source/sink #5577

Closed
christophd opened this issue Jun 4, 2024 · 0 comments · Fixed by #5597
Closed

Consistently support "cloudEventsType" property in Pipes source/sink #5577

christophd opened this issue Jun 4, 2024 · 0 comments · Fixed by #5597
Assignees
@christophd
Labels
area/knative Related to Knative kind/feature New feature or request
Milestone
2.4.0

Comments

@christophd
Copy link
Contributor

Requirement

Consistently support property settings on both source and sink in Pipes when connecting with a Knative broker.

Problem

When a Pipe references a Knative broker as a sink users are able to specify the CloudEvents event type using the cloudEventsType property setting. This controls the event type that is produced by the Pipe.

On the source side when the Pipe consumes the event stream from a Knative broker users need to use type property setting instead. This filters the event stream for events of a given type.

The different names of properties is misleading and we should consistently support the same settings on both source and sink when connecting with the Knative broker.

Proposal

No response

Open questions

No response
@christophd christophd added the kind/feature New feature or request label Jun 4, 2024
@squakez squakez added the area/knative Related to Knative label Jun 4, 2024
@christophd christophd self-assigned this Jun 5, 2024
christophd added a commit to christophd/camel-k that referenced this issue Jun 6, 2024
@christophd
fix: Improve Knative trigger filter
d98000c 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
@christophd christophd mentioned this issue Jun 6, 2024
Merged
christophd added a commit to christophd/camel-k that referenced this issue Jun 6, 2024
@christophd
fix: Improve Knative trigger filter
10b7916 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 7, 2024
@christophd
fix: Improve Knative trigger filter
6c5a6be 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 7, 2024
@christophd
fix: Improve Knative trigger filter
656ddb3 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 7, 2024
@christophd
fix: Improve Knative trigger filter
c62573e 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 7, 2024
@christophd
fix: Improve Knative trigger filter
7494735 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 7, 2024
@christophd
fix: Improve Knative trigger filter
d2a03df 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 7, 2024
@christophd
fix: Improve Knative trigger filter
18e4941 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 10, 2024
@christophd
fix: Improve Knative trigger filter
b0cd014 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
christophd added a commit to christophd/camel-k that referenced this issue Jun 10, 2024
@christophd
fix: Improve Knative trigger filter
a7e8abe 
- Fixes apache#5537: Support filter attributes other than event type (e.g. source, subject, extensions)
- Fixes apache#5529: Allows empty filter to consume the full event stream
- Fixes apache#5446: Knative Trigger creation is only based on event type attribute
- Fixes apache#5577: Consistently support "cloudEventsType" property in Pipes source/sink
- Update documentation and improve Knative Kamelet/Pipe user guide
@christophd christophd added this to the 2.4.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophd christophd

Labels
area/knative Related to Knative kind/feature New feature or request
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

fix: Improve Knative trigger filter christophd/camel-k
2 participants
@christophd @squakez