Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set reply=false by default from knative broker and channel #1619

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Set reply=false by default from knative broker and channel #1619

merged 1 commit into from
Jul 17, 2020

Conversation

nicolaferraro
Copy link
Member

@nicolaferraro nicolaferraro commented Jul 16, 2020 •
edited
Loading

Fix #1617
Fix #1308

Integrations like:

from("knative:event/evt.type")...

(also from channel) are now "in-only" by default, unless the user specifies:

from("knative:event/evt.type?reply=true")

which makes them in-out (brokers and channels accept replies, but it's not so common to use this feature).

Release Note

When subscribing to a Knative channel or broker, replies are ignored unless explicitly enabled

@nicolaferraro nicolaferraro added the kind/feature New feature or request label Jul 16, 2020
@nicolaferraro nicolaferraro merged commit c0f47e8 into apache:master Jul 17, 2020
@nicolaferraro nicolaferraro mentioned this pull request Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@nicolaferraro @lburgazzoli