Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add all sorts of linters and pre-commit hook #257

Merged
merged 2 commits into from
Dec 5, 2018
Merged

chore: add all sorts of linters and pre-commit hook #257

merged 2 commits into from
Dec 5, 2018

Commits on Dec 5, 2018

  1. chore: add all sorts of linters and pre-commit ... 

    ...hook

This adds a myriad of linters from golangci/golangci-lint[1] and a
pre-commit hook to execute them on `git commit`. Some lint checks needed
to be disabled to keep the PR not to big to merge.

To install pre-commit look at the Installation instructions[2] of
pre-commit project.

To install golangci-lint follow the Local Installation instructions[3].

[1] https://github.com/golangci/golangci-lint
[2] https://pre-commit.com/#install
[3] https://github.com/golangci/golangci-lint#local-installation
    @zregvart
    zregvart committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    144e04d View commit details
    Browse the repository at this point in the history

  2. fix: removed cmd.ParseFlags

    @zregvart
    zregvart committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    9274f4c View commit details
    Browse the repository at this point in the history