Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traits lifecycle #273

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Traits lifecycle #273

merged 3 commits into from
Dec 10, 2018

Conversation

lburgazzoli
Copy link
Contributor

Some experiment about traits life-cycle see #268

@lburgazzoli lburgazzoli added the status/wip Work in progress label Dec 8, 2018
nicolaferraro
nicolaferraro approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@nicolaferraro
Copy link
Member

Maybe we should find a way to configure the trait from the profile.
I.e. instead of if profile == 'x' in the trait, maybe better instantiating the trait with a specific property when choosing the profile. Wdyt?

@lburgazzoli
Copy link
Contributor Author

I do agree.

@lburgazzoli lburgazzoli removed the status/wip Work in progress label Dec 10, 2018
@lburgazzoli lburgazzoli changed the title [DO NOT MERGE] Traits lifecycle Traits lifecycle Dec 10, 2018
@lburgazzoli lburgazzoli merged commit d51bb0d into apache:master Dec 10, 2018
@lburgazzoli lburgazzoli deleted the traits branch December 10, 2018 15:02
@lburgazzoli lburgazzoli mentioned this pull request Dec 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lburgazzoli @nicolaferraro