Resolve camel catalog from custom resource #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astefanutti mind doing a review ? |
lburgazzoli
force-pushed
the
github-302
branch
from
6f51705
to
7e1e6e7
Compare
lburgazzoli
force-pushed
the
github-302
branch
from
7e1e6e7
to
006c77a
Compare
astefanutti
reviewed
Feb 11, 2019
pkg/util/camel/camel_util.go
Outdated
| } | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("unable to find default catalog from embedded resources") |
There was a problem hiding this comment.
The catalog list argument can originate from different sources, like resources loaded from the server. So the message should be updated. Otherwise, we can return nil and leave the error handling to the caller.
There was a problem hiding this comment.
@astefanutti done
astefanutti
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
Fixes #414