-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field 'camel-version' to Integration CRD #442
Conversation
fd3f332
to
8ca2e47
Compare
selectors := []string{ | ||
fmt.Sprintf("camel.apache.org/integration=%s", e.Integration.Name), | ||
fmt.Sprintf("camel.apache.org/generation,camel.apache.org/generation notin (%d)", e.Integration.GetGeneration()), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astefanutti I had to split the line to fix lint findings, can you check it it is still ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lburgazzoli I knew that line was way too long 😉! While we are at it, you could split the second selector as well for consistency. Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
res = append(res, item) | ||
} | ||
|
||
res = append(res, list.Items...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Forgot to update it :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries
8ca2e47
to
f09e132
Compare
f09e132
to
90c88eb
Compare
Fixes #439