Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knative): remove Broker type limitation #5580

Closed
wants to merge 1 commit into from

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jun 4, 2024

Close #5529

Release Note

fix(knative): remove Broker type limitation

@squakez squakez added the kind/bug Something isn't working label Jun 4, 2024
@christophd
Copy link
Contributor

I think we are mixing up things here a bit. The type information is not the broker name but the cloud event type set as a field on the cloud event message.

We should not set this to the broker name using e.Ref.Name as supposed in this PR.

Copy link
Contributor

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a misunderstanding. The mentioned type limitation in the issue is not the broker name but the cloud event type applied as a filter on the Trigger created by Camel K.

@squakez squakez closed this Jun 5, 2024
@squakez squakez deleted the fix/5529 branch June 5, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

property "type" must be provided when reading from the Broker
2 participants