-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#38: add uninstall command #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one too is wrong.
rebased and pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments for a few things I noticed.
Would also be good to have an e2e test to prove that the uninstall command is working as desired.
thank you @jamesnetherton, I have pushed the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some resources have not deleted after uninstall
[dvolodin@dvolodin camel-k]$ oc get all,pvc,configmap,rolebindings,clusterrolebindings,secrets,sa,roles,clusterroles,crd -l 'app=camel-k'
NAME TYPE FROM LATEST
buildconfig.build.openshift.io/camel-k-kit-bkvghlo2qg41c2hgbbkg Source Binary 1
NAME TYPE FROM STATUS STARTED DURATION
build.build.openshift.io/camel-k-kit-bkvghlo2qg41c2hgbbkg-1 Source Binary Complete 2 days ago 9s
NAME DOCKER REPO TAGS UPDATED
imagestream.image.openshift.io/camel-k-kit-bkvghlo2qg41c2hgbbkg 172.30.1.1:5000/myproject/camel-k-kit-bkvghlo2qg41c2hgbbkg 948792 2 days ago
NAME DATA AGE
configmap/camel-k-maven-settings 1 2d
NAME AGE
rolebinding.rbac.authorization.k8s.io/camel-k-operator 2d
NAME SECRETS AGE
serviceaccount/camel-k-operator 2 2d
NAME AGE
role.rbac.authorization.k8s.io/camel-k-operator 2d
integrations pods become orphans without integration definition
[dvolodin@dvolodin camel-k]$ ./kamel get
Error: no matches for kind "Integration" in version "camel.apache.org/v1alpha1"
[dvolodin@dvolodin camel-k]$ oc get pods
NAME READY STATUS RESTARTS AGE
camel-k-kit-bkvghlo2qg41c2hgbbkg-1-build 0/1 Completed 0 2d
greetings-6cdc5d9ffd-bdp8r 1/1 Running 0 10m
Please run lint checks as the CI build reports a number of failures on this change. |
@dmvolod and @jamesnetherton thank you for your input. I have gone through the changes and applied to the pull request. Please see below the manual lint and resource uninstall verification procedure logs. lint log
resource uninstall log
|
@ipolyzos CI env again fails. Please see details. |
I can not replicate the issue with Please see the log below
|
I tried P.S |
What's the status here? |
# Conflicts: # go.mod # go.sum # pkg/cmd/root.go
e2e tests added if you please review |
if you please review the most recent changes |
reopening |
CI tests for the uninstall steps failed. But I verified locally and it was all ok. I forget that on Travis, the integration tests run as a non-privileged user and does not have permission to delete cluster resources like CRDs etc. To get this work merged, maybe for now we comment out or skip the uninstall tests and I'll follow up with a fix later on. |
+1 |
thank you |
Superseded by #1254. |
No description provided.