Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant disableXmlReifiers build step #6480

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove redundant disableXmlReifiers build step #6480

merged 1 commit into from
Sep 17, 2024

Conversation

jamesnetherton
Copy link
Contributor

Opening in draft initially to determine if this code is really needed or not.

@jamesnetherton jamesnetherton marked this pull request as ready for review September 17, 2024 13:51
aldettinger
aldettinger approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to remove, no idea why it is there.

@jamesnetherton jamesnetherton merged commit 56e1b82 into apache:main Sep 17, 2024
24 checks passed
@jamesnetherton jamesnetherton deleted the remove-disableXmlReifiers branch September 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldettinger aldettinger aldettinger approved these changes

@zbendhiba zbendhiba zbendhiba approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesnetherton @oscerd @zbendhiba @aldettinger