Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): onboard Observability Services #6860

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Dec 9, 2024

Closes #6790

@squakez squakez marked this pull request as ready for review December 10, 2024 09:49
@squakez
Copy link
Contributor Author

squakez commented Dec 10, 2024

Thanks for the review @jamesnetherton. I think this is complete now. Please, have another look and let's wait for checks results.

extensions/cassandraql/runtime/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@squakez squakez force-pushed the feat/6790_obs_svc branch 2 times, most recently from f232b3e to eaaed5d Compare December 10, 2024 10:05
@@ -84,6 +84,7 @@ group-04:
- mongodb-grouped
- mybatis
- sjms-artemis-client
- observability-services
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put this where there was the micrometer. However not sure which is the correct group to choose from :/

@squakez squakez force-pushed the feat/6790_obs_svc branch 2 times, most recently from bdd8be3 to dbeaa78 Compare December 10, 2024 11:46
@jamesnetherton
Copy link
Contributor

The native test failure was unrelated.

@squakez if you have nothing further to add. I'll merge this now before camel-main starts to drift with future changes.

@squakez
Copy link
Contributor Author

squakez commented Dec 10, 2024

The native test failure was unrelated.

@squakez if you have nothing further to add. I'll merge this now before camel-main starts to drift with future changes.

Okey, yes please merge. Also, let me know if something is required in order to eventually get it on main or it will be automatically moved when we'll move to 4.10 release.

@jamesnetherton
Copy link
Contributor

it will be automatically moved when we'll move to 4.10 release.

It'll be part of the PR that upgrades us to Camel 4.10.0, so nothing for you to do there 👍.

@jamesnetherton jamesnetherton merged commit e5408e0 into camel-main Dec 10, 2024
23 of 24 checks passed
@squakez squakez deleted the feat/6790_obs_svc branch December 10, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants