-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-11942: Switched to jaxb2-maven-plugin for camel-spring schemagen #2099
Conversation
@johnpoth was there something about this maven plugin was not working on java 9 ? @sermojohn did you by any chance test this with java 9 as well. |
Hi @davsclaus, you're right the plugin doesn't work in Java 9, the issue is still open. @sermojohn We use CXF's xjc plugin in the meantime. |
Hi @johnpoth and @davsclaus , |
@johnpoth what do you think about the update? |
I did not find a schemagen goal available in cxf's xjc maven plugin, so I assume it is not available. However, there is a work-around for jaxb2-maven-plugin on Java 9, by manually setting the missing dependencies of the plugin. |
Unit tests are failing On Java 9. Looks like there is a problem with the generated schema:
@sermojohn can you reproduce? If this is another problem with the plugin you can try out the native schemagen which we use for camel-blueprint |
@johnpoth thank you for the notice. Indeed they are failing on my side as well. I believe that camel-blueprint will have the same issue that I am trying to fix for camel-spring module. The problem seems to be that XML schema generation ignores some namespace prefixes, which results in parsing errors when trying to use the generated XML schema (on Java 9). I spent some time on this but have not found what causes this behavior. |
@sermojohn I don't see it worthwhile spending too much time on this as the jaxb2-maven-plugin team are working on supporting Java 9. |
@johnpoth thank you very much. This work-around works on windows as well. |
Have not tested with JDK 9. My initial problem where i had JDK8 with this fix seems OK.. PS : I have seen on the net many people said they used long path tool where i could not find relevant documentation to fix. This PR looked better Thanks guys involved. |
… using exec-maven-plugin. This fix makes the build succeed on windows. Also applied a work-around for correct schemagen on Java 9.
b45d44b
to
18b7ced
Compare
LGTM |
squashed and rebased. ready for merge. |
Thanks for this pull request! |
This fix makes the build succeed on windows.