JAVA-3033 - Consider handling IOException in a manner consistent with other exceptions in CloudConfigFactory.fetchProxyMetadata() #1609
Conversation
|
This PR originally is about handling the IOE from HttpsURLConnection.getInputStream() call in fetchProxyMetaData method which was triggered by 401 request error. During the Unit test, we also found it also needs to handle the FileNotFoundException triggered by 404 error code when the metadata request URL is not correct or the service cannot be located. |
… other exceptions in CloudConfigFactory.fetchProxyMetadata()
hhughes
force-pushed
the
java3033
branch
2 times, most recently
from
fc66bca
to
296ad86
Compare
|
Taking over this PR so we can close out this feature branch.
|
- Move FNF handling to before IOE (FNF is subclass of IOE) - Update tests to assert exact message strings - add test for bad gateway (502) from /metadata - remove wildcard exceptions
| } catch (FileNotFoundException e) { | ||
| throw new IllegalStateException( | ||
| "Metadata service request path not found. Please make sure the metadata service url is correct", | ||
| e); |
There was a problem hiding this comment.
This change relies on undocumented behaviour (HttpsURLConnection throwing FNFE in this case). We should either find a more conventional way to note this case or else remove the special logging for this specific code path.
| throw new IllegalStateException( | ||
| "Unable to read data from cloud metadata service. Please make sure your cluster is not parked or terminated", | ||
| ioe); | ||
| } |
There was a problem hiding this comment.
I'd like for more targeted catch blocks here. As it is the exceptions indicated here could be thrown by either HttpsURLConneciton.getInputStream(), the InputStreamReader constructor or the BufferedReader constructor.
No description provided.