JAVA-3083 Doc updates for new features in 4.17.0 #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hhughes I believe I covered everything we aimed to include with this ticket. If you see something is missing please note it here and I'll fix it. |
absurdfarce
commented
Jul 11, 2023
hhughes
reviewed
Jul 11, 2023
hhughes
reviewed
Jul 11, 2023
hhughes
reviewed
Jul 11, 2023
hhughes
reviewed
Jul 11, 2023
hhughes
reviewed
Jul 11, 2023
jgillenwater
suggested changes
Jul 12, 2023
Co-authored-by: Jamie Gillenwater <jamie.gillenwater@datastax.com>
Co-authored-by: Jamie Gillenwater <jamie.gillenwater@datastax.com>
Co-authored-by: Jamie Gillenwater <jamie.gillenwater@datastax.com>
Co-authored-by: Jamie Gillenwater <jamie.gillenwater@datastax.com>
hhughes
reviewed
Jul 12, 2023
upgrade_guide/README.md
Outdated
| ```java | ||
| try (CqlSession session = new CqlSessionBuilder().withLocalDatacenter("datacenter1").build()) { | ||
|
|
||
| session.execute("drop keyspace if exists test"); |
There was a problem hiding this comment.
nit: is the drop keyspace line neccessary for this example?
There was a problem hiding this comment.
Perhaps not strictly necessary but I'd argue it's certainly a good practice. Including it here communicates the idea that this example should reset its state before it runs; I want to cut off any cases of the test code not working because the user already had a "test" keyspace defined.
hhughes
approved these changes
Jul 12, 2023
jgillenwater
suggested changes
Jul 12, 2023
Co-authored-by: Jamie Gillenwater <jamie.gillenwater@datastax.com>
Co-authored-by: Jamie Gillenwater <jamie.gillenwater@datastax.com>
jgillenwater
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.