Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` #8557

GaOrtiga · 2024-01-23T18:21:07Z

The algorithm firstfitleastconsumed orders the secondary storages based on how much free capacity each has and returns the first item of the list that has enough free capacity. However, the ordering of this list is inverted, putting the storages with the least free capacity at the top.

This behaviour has been adjusted, altering the order of the list to guarantee that the secondary storages with the most free capacity get allocated first.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

codecov · 2024-01-24T04:35:10Z

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 15.81%. Comparing base (7d95952) to head (65e4a7d).

Files with missing lines	Patch %	Lines
...e/image/manager/ImageStoreProviderManagerImpl.java	0.00%	11 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #8557     +/-   ##
===========================================
  Coverage     15.81%   15.81%             
  Complexity    12553    12553             
===========================================
  Files          5629     5629             
  Lines        492015   492001     -14     
  Branches      61440    62810   +1370     
===========================================
+ Hits          77813    77822      +9     
+ Misses       405879   405859     -20     
+ Partials       8323     8320      -3

Flag	Coverage Δ
uitests	`4.48% <ø> (ø)`
unittests	`16.60% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java

sureshanaparti · 2024-01-24T06:04:05Z

@blueorangutan package

blueorangutan · 2024-01-24T06:06:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-01-24T07:16:41Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8428

DaanHoogland

clgtm

github-actions · 2024-02-08T13:19:11Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

GutoVeronezi

CLGTM

GaOrtiga · 2024-03-01T17:06:22Z

@blueorangutan package

blueorangutan · 2024-03-01T17:08:03Z

@GaOrtiga a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-01T18:18:54Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8833

DaanHoogland · 2024-03-04T10:59:54Z

@sureshanaparti is this ok now? do we need more testing?

JoaoJandre · 2024-04-16T12:49:48Z

@blueorangutan package

blueorangutan · 2024-04-16T12:52:03Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-16T14:04:38Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9278

JoaoJandre · 2024-04-16T14:55:31Z

@DaanHoogland @sureshanaparti @rohityadavcloud @shwstppr could we run the CI here?

DaanHoogland · 2024-04-16T15:05:21Z

ping @sureshanaparti

BryanMLima · 2024-04-24T13:44:53Z

@sureshanaparti could you trigger the CI here?
cc @DaanHoogland

DaanHoogland · 2024-04-25T06:44:54Z

@sureshanaparti could you trigger the CI here? cc @DaanHoogland

sorry @BryanMLima , our lab is a bit tired at the moment. I first wanted to hear from @sureshanaparti if he is alright with the current state of the PR

DaanHoogland · 2024-04-25T06:45:02Z

@blueorangutan test

blueorangutan · 2024-04-25T06:46:05Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-04-25T21:15:23Z

[SF] Trillian test result (tid-10013)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50003 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8557-t10013-kvm-centos7.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	312.05	test_events_resource.py
test_01_events_resource	`Error`	312.06	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	94.86	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.50	test_network_permissions.py
test_hostha_enable_ha_when_host_disabled	`Error`	4.99	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	304.10	test_hostha_kvm.py

BryanMLima · 2024-06-12T18:22:23Z

@DaanHoogland @sureshanaparti, could you trigger the CI here?

github-actions · 2024-06-25T14:12:07Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2024-06-25T15:17:29Z

@BryanMLima @GaOrtiga pls resolve the conflicts. thanks.

JoaoJandre · 2024-07-24T12:28:06Z

@blueorangutan package

blueorangutan · 2024-07-24T12:30:05Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-24T15:37:30Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10462

JoaoJandre · 2024-08-13T19:33:32Z

@blueorangutan package

blueorangutan · 2024-08-13T19:34:03Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-13T20:19:37Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10639

blueorangutan · 2024-08-14T14:05:41Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10657

…onsumed`

GaOrtiga · 2024-09-18T19:14:57Z

@blueorangutan package

blueorangutan · 2024-09-18T19:16:03Z

@GaOrtiga a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-18T20:23:07Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11147

DaanHoogland · 2024-09-19T18:35:44Z

@blueorangutan LLtest

blueorangutan · 2024-09-19T18:38:03Z

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

boring-cyborg bot added the component:storage label Jan 23, 2024

sureshanaparti reviewed Jan 24, 2024

View reviewed changes

...src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java Outdated Show resolved Hide resolved

DaanHoogland approved these changes Jan 24, 2024

View reviewed changes

github-actions bot added status:has-conflicts and removed status:has-conflicts labels Feb 8, 2024

GutoVeronezi approved these changes Feb 14, 2024

View reviewed changes

rohityadavcloud added this to the 20.0.0 milestone Feb 16, 2024

github-actions bot added the status:has-conflicts label Jun 25, 2024

github-actions bot removed the status:has-conflicts label Jun 26, 2024

DaanHoogland closed this Jul 1, 2024

DaanHoogland reopened this Jul 1, 2024

JoaoJandre modified the milestones: 4.20.0.0, 4.21.0.0 Sep 10, 2024

Fix ordering of secondary storages with the algorithm `firstfitleastc…

51b2b50

…onsumed`

GaOrtiga force-pushed the fix_ordering_of_storages_with_firstfitleastconsumed branch from 2032c78 to b521a8f Compare September 18, 2024 19:12

return store without checking all

65e4a7d

GaOrtiga force-pushed the fix_ordering_of_storages_with_firstfitleastconsumed branch from b521a8f to 65e4a7d Compare September 18, 2024 19:13

Fix ordering of secondary storages with the algorithm firstfitleastconsumed #8557

Are you sure you want to change the base?

Fix ordering of secondary storages with the algorithm firstfitleastconsumed #8557

Conversation

GaOrtiga commented Jan 23, 2024

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

codecov bot commented Jan 24, 2024 • edited Loading

Codecov Report

sureshanaparti commented Jan 24, 2024

blueorangutan commented Jan 24, 2024

blueorangutan commented Jan 24, 2024

DaanHoogland left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 8, 2024

GutoVeronezi left a comment • edited Loading

Choose a reason for hiding this comment

GaOrtiga commented Mar 1, 2024

blueorangutan commented Mar 1, 2024

blueorangutan commented Mar 1, 2024

DaanHoogland commented Mar 4, 2024

JoaoJandre commented Apr 16, 2024

blueorangutan commented Apr 16, 2024

blueorangutan commented Apr 16, 2024

JoaoJandre commented Apr 16, 2024

DaanHoogland commented Apr 16, 2024

BryanMLima commented Apr 24, 2024

DaanHoogland commented Apr 25, 2024

DaanHoogland commented Apr 25, 2024

blueorangutan commented Apr 25, 2024

blueorangutan commented Apr 25, 2024

BryanMLima commented Jun 12, 2024

github-actions bot commented Jun 25, 2024

sureshanaparti commented Jun 25, 2024

JoaoJandre commented Jul 24, 2024

blueorangutan commented Jul 24, 2024

blueorangutan commented Jul 24, 2024

JoaoJandre commented Aug 13, 2024

blueorangutan commented Aug 13, 2024

blueorangutan commented Aug 13, 2024

blueorangutan commented Aug 14, 2024

GaOrtiga commented Sep 18, 2024

blueorangutan commented Sep 18, 2024

blueorangutan commented Sep 18, 2024

DaanHoogland commented Sep 19, 2024

blueorangutan commented Sep 19, 2024

Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` #8557

Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` #8557

codecov bot commented Jan 24, 2024 •

edited

Loading

GutoVeronezi left a comment •

edited

Loading