-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated instruction MAINTAINER #8846
Removed deprecated instruction MAINTAINER #8846
Conversation
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Not sure which version or branch I should target to resolve conflicts :/ |
@OlegChuev ,Did you test this? can you add test description(s)? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8846 +/- ##
=========================================
Coverage 13.16% 13.16%
Complexity 9203 9203
=========================================
Files 2724 2724
Lines 258153 258153
Branches 40236 40236
=========================================
Hits 33982 33982
Misses 219866 219866
Partials 4305 4305 ☔ View full report in Codecov by Sentry. |
Tested only I manually build container with And as a result I got
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
tested a docker image
# docker inspect cloudstack-simulator | jq -r '.[0].Config.Labels'
{
"Author": "Apache CloudStack <dev@cloudstack.apache.org>",
"License": "ApacheV2",
"Vendor": "Apache.org",
"Version": "4.18.3.0-SNAPSHOT",
"org.opencontainers.image.ref.name": "ubuntu",
"org.opencontainers.image.version": "22.04"
}
Description
This PR...
Removes deprecated MAINTAINER instruction from all Dockerfiles and uses LABEL instead
https://docs.docker.com/reference/dockerfile/#maintainer-deprecated
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?