-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPVM: move focus on input area after clearing clipboard #9669
CPVM: move focus on input area after clearing clipboard #9669
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9669 +/- ##
============================================
+ Coverage 15.08% 15.11% +0.02%
+ Complexity 11192 11188 -4
============================================
Files 5406 5406
Lines 473215 473215
Branches 61680 61293 -387
============================================
+ Hits 71386 71510 +124
- Misses 393880 393898 +18
+ Partials 7949 7807 -142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
actually, a simulated test env is not useful for this... |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
@DaanHoogland |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
[LL] Trillian Build Failed (tid-7026) |
tested in a lab env; can enter any command and send it. If followed by a newline it will be executed. pressing clear will focus on the edit box and a new command can be entered. (too bad paste from the console back doesn't work) |
Description
When click "Clear" button in the clipboard dialog on vm console, the input area is cleared but the page still focuses on the "Clear" button.
It is inconvenient for end users as normally users want to re-input after clearing the input.
This PR moves the focus on the input area after clearing.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?