Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPVM: move focus on input area after clearing clipboard #9669

Conversation

weizhouapache
Copy link
Member

Description

When click "Clear" button in the clipboard dialog on vm console, the input area is cleared but the page still focuses on the "Clear" button.
It is inconvenient for end users as normally users want to re-input after clearing the input.

This PR moves the focus on the input area after clearing.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.11%. Comparing base (a0932b0) to head (fab4dae).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9669      +/-   ##
============================================
+ Coverage     15.08%   15.11%   +0.02%     
+ Complexity    11192    11188       -4     
============================================
  Files          5406     5406              
  Lines        473215   473215              
  Branches      61680    61293     -387     
============================================
+ Hits          71386    71510     +124     
- Misses       393880   393898      +18     
+ Partials       7949     7807     -142     
Flag Coverage Δ
uitests 4.76% <ø> (+0.46%) ⬆️
unittests 15.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@DaanHoogland DaanHoogland added this to the 4.19.2.0 milestone Sep 11, 2024
@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9669 (QA-JID-445)

@DaanHoogland
Copy link
Contributor

actually, a simulated test env is not useful for this...

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Member Author

actually, a simulated test env is not useful for this...

@DaanHoogland
indeed, need a real cpvm for testing

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11096

Copy link
Collaborator

@FelipeM525 FelipeM525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM!

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

[LL] Trillian Build Failed (tid-7026)

@DaanHoogland
Copy link
Contributor

tested in a lab env; can enter any command and send it. If followed by a newline it will be executed. pressing clear will focus on the edit box and a new command can be entered.

(too bad paste from the console back doesn't work)

@rohityadavcloud rohityadavcloud merged commit a8ab47b into apache:4.19 Sep 17, 2024
25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-cpvm-focus-clipboard-after-clear branch September 17, 2024 10:51
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants