Enable Backup and Recovery for Shared Filesystems

[abh1sar]

Description

This PR allows Backup and Recovery operations on Shared FileSystem Instances.

• It was disallowed earlier to reduce interactions
• Prospect users suggested that it is a very useful feature to have and will negatively impact feature adoption
• Backup and Recovery works out of the box with Shared FIleSystems Instances as with any other instance. No special changes are required to support it. I only had to remove certain checks.
• This change has no interaction with any other subsystem of cloudstack.
• Tested all workflows with NAS BnR plugin.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (a88967b) to head (f69bd9d).
Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9676     +/-   ##
===========================================
  Coverage     15.81%   15.81%             
  Complexity    12554    12554             
===========================================
  Files          5629     5629             
  Lines        492029   492013     -16     
  Branches      61304    63525   +2221     
===========================================
  Hits          77811    77811             
+ Misses       405894   405878     -16     
  Partials       8324     8324             

Flag	Coverage Δ
uitests	4.48% <ø> (ø)
unittests	16.60% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11109

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11110

[abh1sar]

@blueorangutan ui

[blueorangutan]

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9676 (QA-JID-449)

[DaanHoogland]

looks good, but can you provide some background @abh1sar ? (why was it disabled first and why is that no longer necessary)

[rohityadavcloud]

LGTM didn't test it

[borisstoyanov]

looks good, but can you provide some background @abh1sar ? (why was it disabled first and why is that no longer necessary)

prospect users reported that the Shared Filesystem feature would be deemed unusable without backups enabled and we identified the functionality as blocker for the feature, that's why we decided to included it as well, I'm currently testing it. Thanks.

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[borisstoyanov]

LGTM,
I've tested this with NAS plugin setup for backups and was able to cover all of the main functions of backups (create, delete, schedule, remove etc).

[weizhouapache]

code lgtm

[blueorangutan]

[SF] Trillian test result (tid-11486)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50611 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9676-t11486-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[abh1sar]

@JoaoJandre This is deemed a blocker for the Shared FileSystems feature. The change involves removing certain checks related to Shared FileSystems Instances and BnR. BnR works with Shared FS Instances like any other instance without any need for code change. This change doesn't affect other subsystems in any way.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11127

[DaanHoogland]

I think that the prior smoke tests are still valid and we are ready to merge.

[rohityadavcloud]

@JoaoJandre over to you to review. This is considered blocker wrt the new feature, though not necessarily a regression/blocker for normal/usual operations.
Re-running test (though not strictly required)
@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11495)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 61665 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9676-t11495-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	405.17	test_vm_life_cycle.py
ContextSuite context=TestHostMaintenanceAgents>:setup	Error	1451.38	test_host_maintenance.py

[JoaoJandre]

Code LGTM. But this is not really a blocker, is it? I can see that it is important to the feature overall but not having this will not break anything. I'll merge this as it is a really simple change that has been tested by the community. But I'll change the label as from the release perspective this is not a blocker and labeling it so is misleading.