Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the lateral expansion of the area-box in the forms (creat… #9681

Conversation

LayonRibeiro
Copy link
Contributor

Description

Currently, the expansion of the textarea field in the quota tariff creation and update forms is limited to vertical growth. This can make the experience unsatisfactory for entering larger texts, as the field does not expand horizontally, which can hinder the visualization and editing of the content.

Changes have been made to the UI to allow the textarea to expand in both directions (vertical and horizontal).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1- Accessed the create form and update form for quota tariff.
2- Verified that the textarea fields now expand horizontally as well as vertically.
3- Ensured that the enhanced textarea functionality works as expected in different scenarios.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (1d4700a) to head (3a5cac7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main    #9681     +/-   ##
===========================================
  Coverage     15.81%   15.81%             
  Complexity    12554    12554             
===========================================
  Files          5629     5629             
  Lines        492029   492029             
  Branches      62293    60003   -2290     
===========================================
+ Hits          77811    77813      +2     
+ Misses       405894   405893      -1     
+ Partials       8324     8323      -1     
Flag Coverage Δ
uitests 4.48% <ø> (ø)
unittests 16.60% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9681 (QA-JID-450)

@DaanHoogland
Copy link
Contributor

@LayonRibeiro , your code looks good but I do not get to edit the quota tariff I am expecting. https://qa.cloudstack.cloud/simulator/pr/9681/#/quotatariff/ . I think there is another biug preventing me from testing the edit functionality. During create the text box epands on request as expected though.

@LayonRibeiro
Copy link
Contributor Author

LayonRibeiro commented Sep 16, 2024

@DaanHoogland , I tested the expansion of the textarea in both the creation and update forms for the rates, and in both cases, I achieved success.

Create form

2024-09-16_15-55

Edit form

2024-09-16_15-52

@LayonRibeiro LayonRibeiro force-pushed the Lateral-expansion-of-the-area-box-in-forms-create/update-of-quota-tariff branch from ec698ee to 3a5cac7 Compare September 16, 2024 19:52
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Sep 17, 2024
@DaanHoogland
Copy link
Contributor

@JoaoJandre I think this is a good to have UI bug fix...?

@JoaoJandre JoaoJandre merged commit 5f80778 into apache:main Sep 17, 2024
25 of 26 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants