Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Improve filtering of VM and template settings #9683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bernardodemarco
Copy link
Collaborator

Description

When manipulating VM and template settings, the UI provides a dropdown with the available setting names and values. However, if a user first adds a setting and then tries to add another, the dropdown only shows the previously added setting's name and value.

Furthermore, whenever the user types a character into the setting name input field, a Vue warning is thrown in the console, stating that an incorrect value type has been passed to the options prop of the a-auto-complete component.

Therefore, this PR improves VM and template settings filtering by always displaying the available setting names and their values, even when a setting has already been added. Besides that, the Vue warning has been properly fixed.


Fixes #8074

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

image

How Has This Been Tested?

  1. When adding the first setting of a VM/template, I verified that all available setting names and their values were displayed correctly in the dropdowns.
  2. I then added another setting, and all available setting names and their values were also displayed correctly.
  3. When typing the setting name in the input field, I confirmed that no warnings were thrown.

@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (1d4700a) to head (216bbfb).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #9683    +/-   ##
==========================================
  Coverage     15.81%   15.81%            
+ Complexity    12554    12553     -1     
==========================================
  Files          5629     5629            
  Lines        492029   492031     +2     
  Branches      62293    61892   -401     
==========================================
+ Hits          77811    77812     +1     
- Misses       405894   405896     +2     
+ Partials       8324     8323     -1     
Flag Coverage Δ
uitests 4.48% <ø> (-0.01%) ⬇️
unittests 16.60% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9683 (QA-JID-448)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested in qa

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test it though

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: only the previous vm/template setting is present in the dropdown when add a new setting
5 participants