-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: load project list with minimum details #9711
Conversation
This calls listProjects with details=min in the global header menu. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9711 +/- ##
============================================
+ Coverage 15.08% 15.11% +0.02%
+ Complexity 11194 11186 -8
============================================
Files 5406 5406
Lines 473184 473230 +46
Branches 58549 59732 +1183
============================================
+ Hits 71398 71527 +129
- Misses 393836 393899 +63
+ Partials 7950 7804 -146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM
tested in qa. @JoaoJandre are we still merging 4.19 bugfixes? |
This calls listProjects with details=min in the global header menu. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This calls listProjects with details=min in the global header menu.
Stole idea/diff from @weizhouapache 's #9679 (comment) :)
Fixes #9679
Types of changes