StorPool: fix of delete snapshot

[slavkap]

Description

This PR fixes the deletion of StorPool snapshots. When a snapshot is deleted, it isn't marked in the DB as such, so when listing the snapshots, the already deleted ones show up.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manual and smoke tests

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (019f2c6) to head (393eb6c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ack/storage/snapshot/StorPoolSnapshotStrategy.java	0.00%	14 Missing ⚠️
...loudstack/storage/datastore/util/StorPoolUtil.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9855      +/-   ##
============================================
- Coverage     15.78%   15.78%   -0.01%     
- Complexity    12564    12565       +1     
============================================
  Files          5627     5627              
  Lines        492250   492258       +8     
  Branches      61405    61911     +506     
============================================
- Hits          77710    77708       -2     
- Misses       406066   406075       +9     
- Partials       8474     8475       +1     

Flag	Coverage Δ
uitests	4.04% <ø> (ø)
unittests	16.60% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[slavkap]

Hi @JoaoJandre, is it possible for this to get in 4.20 because it is a bug in the main and RC2?

[JoaoJandre]

Hi @JoaoJandre, is it possible for this to get in 4.20 because it is a bug in the main and RC2?

Hello @slavkap, sure, since we are waiting other fixes to have the RC3, we can get this in 4.20 still

[slavkap]

Hi @JoaoJandre, is it possible for this to get in 4.20 because it is a bug in the main and RC2?

Hello @slavkap, sure, since we are waiting other fixes to have the RC3, we can get this in 4.20 still

Thank you @JoaoJandre! I made the changes you suggested

[DaanHoogland]

clgtm

[JoaoJandre]

@blueorangutan package

[blueorangutan]

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11469

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[borisstoyanov]

code LGTM

[blueorangutan]

[SF] Trillian test result (tid-11733)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53361 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9855-t11733-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_destroy_ssvm	Error	3.20	test_ssvm.py
test_04_nonsecured_to_secured_vm_migration	Error	396.07	test_vm_life_cycle.py
test_05_vmschedule_test_e2e	Failure	362.09	test_vm_schedule.py