Bump commons-parent from 64 to 65

apache · Dec 3, 2023 · d192244 · d192244
1 parent 867977a
commit d192244
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/pom.xml b/pom.xml
@@ -27,7 +27,7 @@
   <parent>
     <groupId>org.apache.commons</groupId>
     <artifactId>commons-parent</artifactId>
-    <version>64</version>
+    <version>65</version>
   </parent>
 
   <groupId>org.apache.bcel</groupId>
@@ -329,8 +329,8 @@
           <threshold>Normal</threshold>
           <effort>Default</effort>
           <excludeFilterFile>src/conf/spotbugs-exclude-filter.xml</excludeFilterFile>
-          <!-- Hacky: Don't add SpotBugs errors, we have 15 on Java 8, 17 on Java 11 and up --> 
-          <maxAllowedViolations>17</maxAllowedViolations>
+          <!-- Hacky: Don't allow new SpotBugs errors --> 
+          <maxAllowedViolations>8</maxAllowedViolations>
         </configuration>
       </plugin>
       <plugin>

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -92,7 +92,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action                  type="fix" dev="ggregory" due-to="nbauma109, Judit Knoll, Gary Gregory">Fix for type.getType(...) use on non-signature type names #221.</action>
       <action                  type="fix" dev="ggregory" due-to="Gary Gregory">Fix EmptyVisitorTestCase on Java 21.</action>
       <!-- UPDATE -->
-      <action                  type="update" dev="ggregory" due-to="Gary Gregory">Bump commons-parent from 54 to 65 #189, #198, #222.</action>
+      <action                  type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump commons-parent from 54 to 65 #189, #198, #222.</action>
       <action                  type="update" dev="ggregory" due-to="Dependabot">Bump jna.version from 5.12.1 to 5.13.0 #203.</action>
       <action                  type="update" dev="ggregory" due-to="Dependabot">Bump kotlin-stdlib from 1.8.10 to 1.9.21 #217, #219, #227, #231, #235, #245, #247.</action>
       <action                  type="update" dev="ggregory" due-to="Dependabot">Bump commons-io from 2.11.0 to 2.15.1.</action>

diff --git a/src/conf/spotbugs-exclude-filter.xml b/src/conf/spotbugs-exclude-filter.xml
@@ -26,6 +26,12 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd"><!-- N.B. Using wild-card class names so exclusions work regardless of the top-level package -->
 
+  <!-- https://github.com/spotbugs/spotbugs/issues/2710 -->
+  <Match>
+    <Class name="~.*" />
+    <Bug pattern="CT_CONSTRUCTOR_THROW" />
+  </Match>
+
   <!-- Waiting on BCEL-252 -->
   <Match>
     <Class name="~.*\.util\.Class2HTML" />
@@ -54,6 +60,14 @@
     </Or>
   </Match>
 
+  <!-- Binary compatibility -->
+  <Match>
+    <Bug pattern="EI_EXPOSE_STATIC_REP2"/>
+    <Method name="clone"/>
+    <Class name="org\.apache\.bcel\.Repository"/>
+    <Method name="setRepository"/>
+  </Match>
+
   <!-- Reason: TODO, perhaps? -->
   <Match>
     <Class name="~.*" />