Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeanProcessor.java #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rractg
Copy link

@rractg rractg commented Mar 20, 2024

Use classloadercontext in serviceloader. This allows for correct usage when calling this library from within a isolated ClassLoader. A similar change was done in slf4j : qos-ch/slf4j@43a3630

Use classloadercontext in serviceloader. This allows for correct useage when calling this library from within a isolated ClassLoader
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.68%. Comparing base (2ab67d2) to head (669ecd2).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
+ Coverage     62.61%   62.68%   +0.07%     
- Complexity      412      413       +1     
============================================
  Files            39       39              
  Lines          1383     1383              
  Branches        104      104              
============================================
+ Hits            866      867       +1     
+ Misses          468      467       -1     
  Partials         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garydgregory
Copy link
Member

Is there a test you can write to check if this change does anything where changing the main code back would cause it to fail? Otherwise, this is a regression waiting to happen 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants