Add Base64 missing tests and documentation fixes #161
Conversation
| public void testEncodeToString() { | ||
| fail("Not yet implemented"); | ||
| final Base64 base64 = new Base64(); | ||
| final byte[] bytesToEncode = new byte[] {'l', 'i', 'g', 'h', 't', ' ', 'w', 'o', 'r'}; |
There was a problem hiding this comment.
Random question here; was the example intended to be "light work" encoded? 🙂 Asking as it was used in the other tests, but doesn't really matter as this test is working fine 👍
There was a problem hiding this comment.
nope, just a random example from Base64 - Output Padding page in wikipedia 😀
There was a problem hiding this comment.
Random question here; was the example intended to be "light work" encoded? 🙂 Asking as it was used in the other tests, but doesn't really matter as this test is working fine 👍
In the future, we could split up test method per test source, like testWikipediaExamplesAbc, testRfc123FeatureX, and so on.
| * | ||
| * @param pArray A byte array containing Base64 character data | ||
| * @return a byte array containing binary data | ||
| * @return a byte array containing binary data; will return {@code null} if provided byte array is null. |
| @@ -114,10 +114,10 @@ public class Base64 { | |||
| // some state be preserved between calls of encode() and decode(). | |||
|
|
|||
| /** | |||
| * Tests a given byte array to see if it contains only valid characters within the Base64 alphabet. | |||
| * Tests a given byte array to see if it contains any valid character within the Base64 alphabet. | |||
There was a problem hiding this comment.
Oh, I had to read the code to confirm it. To me the updated text looks correct, great catch!
There was a problem hiding this comment.
Looks good to me! Commits need to be squashed but we can take care of that later. Thanks @jkbkupczyk !
FYI @garydgregory @kinow