-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile SDK / Target SDK version not consistent with defaults in root build.gradle #631
Comments
I think this should be done before we try to resolve the issue with AndroidX (#565). I think this issue is similar to #508 (Inconsistent handling of min/target SDK values) and needs to be solved in the Gradle scripts. The solution may be related to PR #633 (quick fix for #508). /cc @davidschreiber |
I am expanding the scope of this issue to cover the compile SDK version, as @davidschreiber pointed out in apache/cordova-plugin-camera#418 (comment) and apache/cordova-plugin-camera#418 (comment). As I said before:
|
- remove defaultTargetSdkVersion which was never used - comment out defaultBuildToolsVersion & defaultCompileSdkVersion with notes that these values should be defined and used someday in the future Resolves apache#658 Resolves apache#631
@brodybits I think we can close this ticket now as PR #699 is merged into master. |
@brodybits I can continue to look into this. I have a plan for another PR which will refactor the Gradle process but the amount of work might not fit into this release version. I will see what can be done in patch/minor releases and keep the major changes in a seperate PR. From the ticket, you linked
|
For this ticket, I can do some additional testing around Target and Compiled SDK. |
Closing this ticket as resolved in Cordova-Android 10. |
If I would do
cordova platform add android@nightly
in a new Cordova project and then docordova build android
, the APK has target SDK version 27 while SDK 28 is specified as default in:cordova-android/bin/templates/project/build.gradle
Lines 45 to 46 in f1f1ac3
I used the following command to check the SDK versions in the APK:
aapt list -a platforms/android/app/build/outputs/apk/debug/app-debug.apk | grep SdkVersion
This issue may be related to #508 - Inconsistent handling of min/target SDK values
I hope we can resolve this one before the next major release for Cordova 9 (apache/cordova#10).
P.S. I expanded the scope of this issue to cover the compile SDK version. This issue needs to be resolved before we can continue with AndroidX support (#565).
The text was updated successfully, but these errors were encountered: