Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support installing platfrom from local git clone #1453

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 30, 2022

Motivation and Context

Ability to install platfrom from local git clone

Description

If require.resolve fails to resolvecordova-android, it is coming from local dir..

Testing

npm t
cordova build
cordova create
cordova platform add

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from NiklasMerz June 30, 2022 12:13
@erisu erisu added the bug label Jun 30, 2022
@erisu erisu added this to the 11.0.0 milestone Jun 30, 2022
@erisu erisu changed the title fix: support installing platfrom from local git checkout fix: support installing platfrom from local git clone Jun 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #1453 (c721dbd) into master (861fec2) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
- Coverage   72.41%   72.25%   -0.17%     
==========================================
  Files          21       21              
  Lines        1744     1748       +4     
==========================================
  Hits         1263     1263              
- Misses        481      485       +4     
Impacted Files Coverage Δ
lib/prepare.js 46.63% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861fec2...c721dbd. Read the comment docs.

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing the platform with a relative path works and the code looks better to read-

@erisu erisu merged commit e968cac into apache:master Jun 30, 2022
@erisu erisu deleted the fix/install-from-local-dir branch June 30, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants