Android build tools 3.3 & Gradle 4.10.3 update #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle 4.10.1 or higher is needed for Android Studio 3.3.0 ref: - https://developer.android.com/studio/releases/gradle-plugin#3-3-0 Resolves apache#634 (Update Gradle classpath for Android Studio 3.3) Resolves apache#596 (Support gradle 4.9+)
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=======================================
Coverage 64.66% 64.66%
=======================================
Files 18 18
Lines 1817 1817
=======================================
Hits 1175 1175
Misses 642 642
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Gradle 4.10.1 or higher is needed for Android Studio 3.3.0 ref: https://developer.android.com/studio/releases/gradle-plugin#3-3-0)
I hope this will be part of the upcoming major release for Cordova 9 (apache/cordova#10).
For the following issues:
I think it would be ideal to update to Gradle 5.1, not convinced we should squeeze this into Cordova 9.
P.S. I verified that no issues were introduced when I tested this change with
cordova-mobile-spec.