Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove callback parameter of main CLI function #316

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Remove callback parameter of main CLI function #316

merged 1 commit into from
Sep 5, 2018

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Aug 30, 2018 •
edited
Loading

Resolves #314. Builds on #315.

@raphinesse raphinesse force-pushed the remove-main-callback branch from 87df63a to de3da0b Compare August 31, 2018 09:43
dpogue
dpogue approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raphinesse raphinesse merged commit c9f29c6 into apache:master Sep 5, 2018
@raphinesse raphinesse deleted the remove-main-callback branch September 5, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphinesse @dpogue