Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova CLI Release Preparation (Cordova 9) #414

Merged
merged 12 commits into from
Mar 20, 2019
Merged

Cordova CLI Release Preparation (Cordova 9) #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0c0e397
Bumped cordova-common@^3.1.0
erisu Mar 18, 2019
c98167f
Bumped cordova-lib@^9.0.0
erisu Mar 18, 2019
be7108e
Bumped editor@^1.0.0
erisu Mar 18, 2019
a9217ec
Bumped loud-rejection@^2.0.0
erisu Mar 18, 2019
460f302
Bumped eslint@eslint . bin/cordova
erisu Mar 18, 2019
90ddd40
Bumped eslint-config-semistandard@^13.0.0
erisu Mar 18, 2019
1d48091
Bumped eslint-config-standard@^12.0.0
erisu Mar 18, 2019
b3e0c29
Bumped eslint-plugin-import@^2.16.0
erisu Mar 18, 2019
4f24693
Bumped eslint-plugin-node@^8.0.1
erisu Mar 18, 2019
863e4e8
Bumped eslint-plugin-promise@^4.0.1
erisu Mar 18, 2019
a895e80
Bumped jasmine@^3.3.1
erisu Mar 18, 2019
f626923
fix to work SpyOn in Jasmine (#1)
knight9999 Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,24 @@
],
"dependencies": {
"configstore": "^4.0.0",
"cordova-common": "^2.2.0",
"cordova-lib": "8.0.0",
"editor": "1.0.0",
"cordova-common": "^3.1.0",
"cordova-lib": "^9.0.0",
"editor": "^1.0.0",
"insight": "^0.10.1",
"loud-rejection": "^1.6.0",
"loud-rejection": "^2.0.0",
"nopt": "^4.0.1",
"update-notifier": "^2.5.0"
},
"devDependencies": {
"eslint": "^5.4.0",
"eslint-config-semistandard": "^12.0.1",
"eslint-config-standard": "^11.0.0",
"eslint-plugin-import": "^2.3.0",
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-promise": "^4.0.0",
"eslint": "^5.15.2",
"eslint-config-semistandard": "^13.0.0",
"eslint-config-standard": "^12.0.0",
"eslint-plugin-import": "^2.16.0",
"eslint-plugin-node": "^8.0.1",
"eslint-plugin-promise": "^4.0.1",
"eslint-plugin-standard": "^4.0.0",
"istanbul": "^0.4.5",
"jasmine": "^3.1.0",
"jasmine": "^3.3.1",
"rewire": "^4.0.1"
},
"author": "Anis Kadri",
Expand Down
16 changes: 16 additions & 0 deletions spec/cli.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,22 @@
const fs = require('fs');
const path = require('path');
const rewire = require('rewire');
/*
After Cordova-Common 3.1.0, logger[level] property becomes not writable.
Therefore we re-define addLevel function here to use SpyOn logger[level]
*/
const CordovaLogger = require('cordova-common').CordovaLogger;
CordovaLogger.prototype.addLevel = function (level, severity, color) {
this.levels[level] = severity;
if (color) {
this.colors[level] = color;
}
// Define own method with corresponding name
if (!this[level]) {
this[level] = this.log.bind(this, level);
}
return this;
};
const { events, cordova } = require('cordova-lib');
const logger = require('cordova-common').CordovaLogger.get();
const telemetry = require('../src/telemetry');
Expand Down