Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-13055: proposal to remove old fetch code #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CB-13055: proposal to remove old fetch code #76

wants to merge 3 commits into from

Conversation

audreyso
Copy link
Contributor

@audreyso audreyso commented Sep 1, 2017 •
edited
Loading

Ready for review! Thank you!

filmaj
filmaj approved these changes Sep 7, 2017
View reviewed changes
Copy link

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A resounding plus one from me.
Do we have any data on how often these modes of fetch that we are proposing to remove are used?

@stevengill
Copy link
Contributor

I'm also on board with this plan.

@macdonst
Copy link
Member

@audreyso just for clarification does this mean I won't be able to do the following:

cordova plugin add https://github.com/phonegap/phonegap-plugin-push#rich

That is install the plugin from a specific branch on github?

@brodycj
Copy link

brodycj commented Jun 3, 2018

What is the status of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj approved these changes

Assignees
No one assigned
Labels
cordova-8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@audreyso @stevengill @macdonst @brodycj @filmaj