Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example on buildConfig #909

Closed
wants to merge 1 commit into from
Closed

Conversation

hiepxanh
Copy link

Platforms affected

Android

What does this PR do?

There is no tutorial or any example on google or the docs. I dont event know that ~ can relate to HOME path. It take me 5 hours to searching, and finally I have to go to source code to read and find out that can help me. I hope on small change can help people working on multi device can easy locate that home path to point to .android folder more easy.

What testing has been done on this change?

Checklist

  • Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where GH-xxxx is the GitHub issue ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio
Copy link
Member

janpio commented Nov 16, 2018

Why is it relevant to know here that ~ is the home directory on some systems? What does this have to do with buildConfig?

@hiepxanh
Copy link
Author

hiepxanh commented Nov 18, 2018

I already answer on this topic sir, [FIX] better support to find home path . Let discussion about this.

@brodycj
Copy link
Contributor

brodycj commented Nov 18, 2018

Thanks @hiepxanh for the proposal, my response is in apache/cordova-cli#359 (comment).

@hiepxanh
Copy link
Author

I should close this issue, shouldn't I sir? @brodybits

Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending conclusion of apache/cordova-android#563 and apache/cordova#48. I think we should also finish apache/cordova-cli#359 before merging this one.

@janpio janpio closed this Mar 1, 2019
breautek added a commit to breautek/cordova-docs that referenced this pull request Oct 28, 2024
breautek added a commit that referenced this pull request Nov 2, 2024
* announcement: cordova-plugin-camera 8.0.0

* Added missing breaking change note for GH-909

* Added known issues / allowEdit notes / missing changelog entries

* moved android AndroidInsecureFileModeEnabled notes to known issues

* Reworded android known issues

* specified that AndroidInsecureFileModeEnabled is a preference

* improved grammer

* improved grammer

* reformatted the document for easiser reading at the source level

* clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants