Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace superspawn with execa #75

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 30, 2019

Motivation and Context

apache/cordova#16

Description

Replace superspawn usage with execa

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 3.0.0 milestone Oct 30, 2019
@erisu erisu requested a review from raphinesse October 30, 2019 02:21
@erisu erisu force-pushed the v3-replace-superspawn-to-execa branch 3 times, most recently from ab6fd6d to 6cea840 Compare November 1, 2019 02:24
package.json Outdated Show resolved Hide resolved
@erisu erisu force-pushed the v3-replace-superspawn-to-execa branch from 6cea840 to 4fa56b4 Compare November 5, 2019 08:19
@erisu erisu requested a review from timbru31 November 5, 2019 08:19
@erisu erisu closed this Mar 24, 2020
@raphinesse raphinesse reopened this Nov 1, 2021
@raphinesse raphinesse force-pushed the v3-replace-superspawn-to-execa branch from 4fa56b4 to a27a7c7 Compare November 1, 2021 15:36
@raphinesse raphinesse modified the milestones: 3.0.0, 4.0.0 Nov 1, 2021
@raphinesse raphinesse changed the title chore: replace superspawn with execa refactor!: replace superspawn with execa Nov 1, 2021
@raphinesse raphinesse force-pushed the v3-replace-superspawn-to-execa branch from a27a7c7 to 42cb66c Compare November 1, 2021 15:39
@raphinesse raphinesse changed the title refactor!: replace superspawn with execa refactor: replace superspawn with execa Nov 1, 2021
@raphinesse raphinesse modified the milestones: 4.0.0, 3.1.0 Nov 1, 2021
@erisu erisu force-pushed the v3-replace-superspawn-to-execa branch from 42cb66c to 0442e4a Compare March 27, 2023 06:17
@erisu erisu modified the milestones: 3.1.0, 4.0.0 Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #75 (0442e4a) into master (23be9ed) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   93.33%   93.44%   +0.10%     
==========================================
  Files           1        1              
  Lines          60       61       +1     
==========================================
+ Hits           56       57       +1     
  Misses          4        4              
Impacted Files Coverage Δ
index.js 93.44% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu requested a review from breautek March 27, 2023 10:59
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should finally merge it.

package.json Show resolved Hide resolved
@erisu erisu merged commit 10d9191 into apache:master Mar 28, 2023
@erisu erisu deleted the v3-replace-superspawn-to-execa branch March 28, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants