Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ios): nil check in didReceiveData in schemehandler #1035

Merged
merged 1 commit into from
Dec 3, 2020
Merged

(ios): nil check in didReceiveData in schemehandler #1035

merged 1 commit into from
Dec 3, 2020

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Dec 2, 2020 •
edited
Loading

Platforms affected

iOS

Motivation and Context

Data can be nil in the WKURLSchemeHandler and should not be passed as a response.

Description

Add simple nil check

Closes #903

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@NiklasMerz NiklasMerz added this to the 6.next milestone Dec 2, 2020
@dpogue dpogue merged commit be1cd7d into master Dec 3, 2020
@dpogue dpogue deleted the fix903 branch December 3, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmtamburro msmtamburro msmtamburro approved these changes

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

CDVURLSchemeHandler.m startURLSchemeTask data can be nil
3 participants
@NiklasMerz @dpogue @msmtamburro