Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: README.md drop support for Xcode pre-9.0 - WIP FOR DISCUSSION #386

Closed
wants to merge 1 commit into from

Conversation

brodycj
Copy link

@brodycj brodycj commented Aug 1, 2018

Platforms affected

iOS

What does this PR do?

TODO:

  • needs discussion
  • raise JIRA issue if agreed
  • update in cordova-docs
  • check if we should drop support for Xcode pre-9.0 in bin and tests?

What testing has been done on this change?

TODO

Checklist

TODO:

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   65.62%   65.62%           
=======================================
  Files          14       14           
  Lines        1702     1702           
  Branches      286      286           
=======================================
  Hits         1117     1117           
  Misses        585      585

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f4bbb...1f87613. Read the comment docs.

@jcesarmobile
Copy link
Member

We can probably drop Xcode 9 too as Xcode 10 will be mandatory starting in March (but only for App Store submissions, some people might still want to use Xcode 9 for enterprise apps)

@brodycj
Copy link
Author

brodycj commented Jan 8, 2019

I am closing this one in favor of new PR #491. I would favor documenting Xcode 9 support as "deprecated", as I proposed in the new PR (#491).

@brodycj brodycj closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants