Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable modern build system for Xcode 10 #410

Closed
wants to merge 1 commit into from

Conversation

mlegenhausen
Copy link
Contributor

@mlegenhausen mlegenhausen commented Sep 17, 2018

Just as requested in #378 I provide my minimal solution.

Platforms affected

iOS 12 with Xcode 10 GM

What does this PR do?

It disables the modern build system of Xcode 10 via a undocumented command line flag for xcodebuild.

What testing has been done on this change?

cordova build ios and cordova run ios (emulator)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change

@dpogue
Copy link
Member

dpogue commented Sep 17, 2018

Our hope is to make the next major version of cordova-ios compatible with the new build system, rather than disabling it.

If you're running into issues with Xcode 10 and need to disable it for your existing projects, there are some workarounds documented here.

@geocolumbus
Copy link

geocolumbus commented Sep 18, 2018

We are building using "buildFlag": ["-UseModernBuildSystem=0"] option in the build.json file with XCode 10 for our iOS12 phones. So this is an excellent workaround. But maybe that flag (and the old build system) will vanish in XCode 11. Anyway, this is a good work around until cordova-ios gets sorted out. We are also mourning the loss of UIWebView and all the problems of migrating to WKWebView for our enterprisy authentication flow. Apple is a handful.

@dpogue
Copy link
Member

dpogue commented Dec 17, 2018

We've merged support for the new build system in preparation for the next major version of cordova-ios, so I'm going to close this. Thanks for your contribution!

@dpogue dpogue closed this Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants