-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] GH-407: supports autormatic provisioning in Xcode 10 #504
[WIP] GH-407: supports autormatic provisioning in Xcode 10 #504
Conversation
I believe all automatic provisioning profiles have |
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
- Coverage 74.75% 68.21% -6.54%
==========================================
Files 11 12 +1
Lines 1822 2020 +198
==========================================
+ Hits 1362 1378 +16
- Misses 460 642 +182
Continue to review full report at Codecov.
|
@dpogue Thanks for the advice.
|
@dpogue Just as you mentioned, all automatic provisionings file are xcode managed. Now I am looking for the solution. Is there any way to export a correct .ipa file from .xcarchive when the automatic provisioning is used? (Wrong .ipa file does not work in ios-deploy debugging) |
As far as I know, the only way to I am now looking for another solution. |
I found that removing following lines
in |
Now my new PR is #508 . |
Platforms affected
cordova-ios
What does this PR do?
To fix the issue #407 in case the automatic provisioning is specified. This PR is according to the comment #407 (comment) .
What testing has been done on this change?
In xcode 10, exporting archives from xcarchive with automatic provisioning has an issue. As a result, ios-deploy debugging does not work correctly. (after launching, it stops soon).
Therefore this PR finds an appropriate provisioning file registered in local mac and uses that file to export an archive (.ipa file) in cordova/lib/build.js.
How to find appropriate provisioing file logic is followings.
Checklist