Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pre-fill orientation #615

Merged
merged 1 commit into from Apr 18, 2020
Merged

Don't pre-fill orientation #615

merged 1 commit into from Apr 18, 2020

Conversation

oliversalzburg
Copy link
Contributor

@oliversalzburg oliversalzburg commented May 9, 2019 •
edited
Loading

Platforms affected

iOS

Motivation and Context

The orientation is already set on each build, taking into account possible preference directives for the Orientation. Pre-setting them here, makes it impossible to reduce the array of available orientations, because config-file can not reduce the elements in an array.

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@oliversalzburg oliversalzburg changed the title Don't pre-fill orientation WIP: Don't pre-fill orientation May 9, 2019
@oliversalzburg oliversalzburg changed the title WIP: Don't pre-fill orientation [WIP] Don't pre-fill orientation May 9, 2019
@oliversalzburg oliversalzburg changed the title [WIP] Don't pre-fill orientation Don't pre-fill orientation May 9, 2019
@oliversalzburg
(ios) Don't pre-fill orientation
a55de1a 
The orientation is already set on each build, taking into account possible `preference` directives for the `Orientation`. Pre-setting them here, makes it impossible to reduce the array of available orientations, because `config-file` can not reduce the elements in an array.
dpogue
dpogue approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@dpogue dpogue merged commit fb49478 into apache:master Apr 18, 2020
This was referenced Jun 15, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasMerz NiklasMerz NiklasMerz approved these changes

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliversalzburg @dpogue @NiklasMerz