Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use template strings #751

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 18, 2019

Motivation and Context

Modernize code

Description

Use lebab to apply --transform template.

Testing

  • npm t

@erisu erisu added this to the 6.0.0 milestone Dec 18, 2019
@erisu erisu requested a review from raphinesse December 18, 2019 00:06
@erisu erisu changed the title V6 transform template strings refactor: use template strings Dec 18, 2019
@erisu erisu force-pushed the v6-transform-template-strings branch from 9f14f1d to c4dcbad Compare December 24, 2019 05:40
@erisu erisu marked this pull request as ready for review December 24, 2019 05:40
@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is 62.65%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          11       11           
  Lines        1830     1830           
=======================================
  Hits         1362     1362           
  Misses        468      468
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/run.js 21.42% <0%> (ø) ⬆️
bin/templates/scripts/cordova/lib/versions.js 90.24% <100%> (ø) ⬆️
bin/templates/scripts/cordova/lib/check_reqs.js 51.94% <100%> (ø) ⬆️
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.45% <100%> (ø) ⬆️
bin/templates/scripts/cordova/Api.js 71.11% <100%> (ø) ⬆️
bin/templates/scripts/cordova/lib/build.js 50.76% <23.07%> (ø) ⬆️
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.2% <66.66%> (ø) ⬆️
bin/templates/scripts/cordova/lib/Podfile.js 73.58% <75%> (ø) ⬆️
bin/templates/scripts/cordova/lib/prepare.js 84.06% <77.77%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2229e45...c4dcbad. Read the comment docs.

@erisu erisu merged commit 266d339 into apache:master Dec 30, 2019
@erisu erisu deleted the v6-transform-template-strings branch December 30, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants