Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run on Xcode 11 only #786

Merged
merged 1 commit into from
Feb 13, 2020
Merged

test: run on Xcode 11 only #786

merged 1 commit into from
Feb 13, 2020

Conversation

jcesarmobile
Copy link
Member

No description provided.

@erisu erisu added this to the 6.0.0 milestone Feb 12, 2020
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu
Copy link
Member

erisu commented Feb 13, 2020

You can rebase this PR with master and it should fix the failing tests now.

I just merged in #782 which fixed the failing tests with the latest node. This will now unblock the reviewing/merging hold up.

@jcesarmobile
Copy link
Member Author

jcesarmobile commented Feb 13, 2020

@dependabot rebase

@erisu bot rebase

Since we are dropping support of older versions
@erisu erisu force-pushed the travis-xcode-tests branch from a1e0347 to 710c048 Compare February 13, 2020 11:46
@erisu
Copy link
Member

erisu commented Feb 13, 2020

/me bot confirmed request, rebase complete

@erisu erisu changed the title chore: run tests on Xcode 11 only test: run on Xcode 11 only Feb 13, 2020
@jcesarmobile jcesarmobile merged commit b0280cf into master Feb 13, 2020
@jcesarmobile jcesarmobile deleted the travis-xcode-tests branch February 13, 2020 13:22
NiklasMerz pushed a commit to GEDYSIntraWare/cordova-ios that referenced this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants