Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: ios-sim ^9.0.0 to ^8.0.2 #862

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented May 21, 2020

Motivation and Context

  '          this.log(`logPath: ${path.resolve(flags.log)}`)\n' +
  '               ^\n' +
  '\n' +
  "TypeError: Cannot read property 'log' of undefined\n" +

Description

  • revert to the latest on 8.x release (^8.0.2)

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 21, 2020
@erisu erisu requested review from shazron, dpogue and timbru31 May 21, 2020 04:19
@codecov-commenter
Copy link

Codecov Report

Merging #862 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1821     1821           
=======================================
  Hits         1355     1355           
  Misses        466      466           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e3bbd...faf5cf8. Read the comment docs.

@erisu
Copy link
Member Author

erisu commented May 21, 2020

Last call on review, this PR will be merged in tomorrow for release.

On top of the scoping issue within ios-sim 9.x, if fixed, the logging to file feature is not implemented it appears as it does not write to the provided log path.

@erisu erisu force-pushed the revert/ios-sim branch from faf5cf8 to 30ca7bf Compare May 22, 2020 08:45
@erisu erisu merged commit 67bea75 into apache:master May 22, 2020
@erisu erisu deleted the revert/ios-sim branch May 22, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants