Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unassigned splash image #873

Merged
merged 1 commit into from
May 27, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 27, 2020

Motivation, Context & Description

Reasons for Removing

  • Removes the unassigned launch image warning.
  • The image is assigned in the platform repo template, but on new project creation the image is unassigned because the prepare step removes the image from assignment. This is because config.xml does not have a splash tag by default.
  • Android does not show splash screen by default, for consistency iOS should not display splash screen as well.

Other Thoughts

  • IF a default splash screen is desired, IMO, it is recommended that the default image and config.xml splash settings are in our default template repo (cordova-app-hello-world).
  • IF a default splash is desired, a default should exist on all core platforms which can be again configured in our default template repo.
  • It is also expected that an end user would replace the splash screen so it may not be required.

Testing

  • npm t
  • cordova platform add
  • cordova build

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1676     1676           
=======================================
  Hits         1247     1247           
  Misses        429      429           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5db54...1e31cce. Read the comment docs.

@erisu erisu merged commit 41459f0 into apache:master May 27, 2020
@erisu erisu deleted the chore/remove-unassigned-splash-image branch May 27, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants