Set the background colour as an xcasset color set #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
requested changes
Jun 10, 2020
There was a problem hiding this comment.
Unit Test Error
Failures:
1) prepare after plugin add Test 001 : should not overwrite plugin metadata added by "addPlugin"
Message:
Error: ENOENT: no such file or directory, open '/tmp/cordova-ios/tests/spec/unit/fixtures/dummyProj/platforms/ios/SampleApp/Images.xcassets/BackgroundColor.colorset/Contents.json'
Stack:
error properties: Object({ errno: -2, syscall: 'open', code: 'ENOENT', path: '/tmp/cordova-ios/tests/spec/unit/fixtures/dummyProj/platforms/ios/SampleApp/Images.xcassets/BackgroundColor.colorset/Contents.json' })
Error: ENOENT: no such file or directory, open '/tmp/cordova-ios/tests/spec/unit/fixtures/dummyProj/platforms/ios/SampleApp/Images.xcassets/BackgroundColor.colorset/Contents.json'
at Object.openSync (fs.js:461:3)
at Object.writeFileSync (fs.js:1387:35)
at updateBackgroundColor (/tmp/cordova-ios/bin/templates/scripts/cordova/lib/prepare.js:88:838)
at /tmp/cordova-ios/bin/templates/scripts/cordova/lib/prepare.js:22:326
Manual Testing
navigator.splashscreen.show()has an unexpected behaviour.
It will fade into what I presume to be the SplashScreen but it only shows a white screen.
navigator.splashscreen.hide()works as expected.
Fades back into the application.
Trying to take a snapshot of the view doesn't seem to result in the image actually being present in the snapshot, but we can just render the view itself from the storyboard file. However, we do need to make sure that we don't allow the view to grow in size, otherwise it will expand to the size of the image instead of remaining the size of the screen bounds.
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 74.40% 74.48% +0.08%
==========================================
Files 13 13
Lines 1676 1713 +37
==========================================
+ Hits 1247 1276 +29
- Misses 429 437 +8
Continue to review full report at Codecov.
|
|
@erisu Thanks for catching that. I've fixed the missing test fixture, and also added a second commit to address the SplashScreen being blank. It should work as intended now 😁 |
erisu
approved these changes
Jun 11, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Resolves #890 where the splashscreen UIView defaults to a transparent background if no
BackgroundColorpreference is specified in config.xml.Description
Add a named color set to Images.xcassets named
BackgroundColorwhich defaults to the system background colour (respecting dark mode). On prepare, it will be set to the value specified in config.xml. Set the LaunchScreen Storyboard to use that as the background colour, and also ensure the WebView and SplashScreen UIView also use it as the background colour.This also hypothetically opens the door for people to (via
<resource-file>tags) provide their own color set content with different values for different devices or different light/dark modes. Caveat that this is not in the realm of supported Cordova behaviour, and we do not make any guarantees about this working.If you're embedding the Cordova ViewController in another app or otherwise don't have a
BackgroundColorcolor set in xcassets, it will fallback to white.Testing
BackgroundColorpreference parsing in prepare.spec.jsChecklist