fix: Fix potential edge case in cordova.js detection #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `indexOf` returns -1 in the case of no match, and a subtraction of string lengths can also potentially result in -1, we want to make sure the index is NOT -1 before we try to substring with it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 83.62% 83.65% +0.03%
==========================================
Files 14 14
Lines 519 520 +1
==========================================
+ Hits 434 435 +1
Misses 85 85 ☔ View full report in Codecov by Sentry. |
erisu
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
indexOfreturns -1 in the case of no match, and a subtraction of string lengths can also potentially result in -1, we want to make sure the index is not -1 before we try to substring with it.