Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows): deprecate platform #852

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Sep 3, 2020

Status

  • pending formal vote

Platforms affected

Windows

Motivation and Context

see this discussion in dev@cordova.apache.org

Description

set "deprecated": true for Windows in src/platforms/platformsConfig.json

Testing

updated:

In a local checkout of cordova-cli:

npm i github:apache/cordova-lib#brodybits-windows-deprecated
./bin/cordova create test1
cd test1

after adding Windows, ../bin/cordova platform ls gives me the following output:

Warning: using prerelease version 10.0.1-dev (cordova-lib@10.0.1-dev)
Installed platforms:
  windows 7.0.1 (deprecated)
Available platforms: 
  android ^9.0.0
  browser ^6.0.0
  electron ^1.0.0
  ios ^6.1.0
  osx ^6.0.0

Checklist

  • I've run the tests to see all new and existing tests pass - see Travis CI ✅
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • I've updated the documentation if necessary

@erisu erisu changed the title (windows): set Windows as deprecated feat(windows): deprecated platform Aug 2, 2022
@erisu erisu changed the title feat(windows): deprecated platform feat(windows): deprecate platform Aug 2, 2022
@erisu erisu marked this pull request as ready for review August 2, 2022 14:09
@erisu
Copy link
Member

erisu commented Aug 2, 2022

Cordova-Windows deprecation notice was already posted to the repo and also Cordova website reflects it.

apache/cordova-windows@0454321

@erisu erisu added this to the 11.1.0 milestone Aug 2, 2022
@erisu erisu force-pushed the brodybits-windows-deprecated branch from 20e890e to 9368657 Compare August 2, 2022 14:10
@erisu
Copy link
Member

erisu commented Aug 2, 2022

I have rebased this PR.

@erisu
Copy link
Member

erisu commented Aug 2, 2022

@brodybits thank you for the PR

@codecov-commenter
Copy link

Codecov Report

Merging #852 (9368657) into master (42b4569) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #852   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          46       46           
  Lines        2123     2123           
=======================================
  Hits         1874     1874           
  Misses        249      249           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@erisu erisu merged commit 387b9a0 into master Aug 8, 2022
@erisu erisu deleted the brodybits-windows-deprecated branch August 8, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants